add proposal for modify the MaxGasUsedPerBlock #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #3241 +/- ##
==========================================
- Coverage 36.57% 36.57% -0.01%
==========================================
Files 444 445 +1
Lines 46663 46705 +42
==========================================
+ Hits 17067 17081 +14
- Misses 28330 28359 +29
+ Partials 1266 1265 -1
|
yann-sjtu
reviewed
Aug 21, 2023
app/config/config.go
Outdated
| @@ -233,6 +234,10 @@ var ( | |||
| confLogger log.Logger | |||
| ) | |||
|
|
|||
| func GetchainMaxGasUsedPerBlock() int64 { | |||
There was a problem hiding this comment.
it should be GetChainMaxGasUsedPerBlock, chain -> Chain
zjg555543
previously approved these changes
Aug 21, 2023
yann-sjtu
approved these changes
Aug 21, 2023
zjg555543
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdReviewed
Files changedin the github PR explorerFor Admin Use: